Skip to content

Updating the readme and intro doc page ahead of v0.8 release#677

Merged
johnjasa merged 7 commits intoNatLabRockies:developfrom
johnjasa:cleanup_readme_and_docs
Apr 15, 2026
Merged

Updating the readme and intro doc page ahead of v0.8 release#677
johnjasa merged 7 commits intoNatLabRockies:developfrom
johnjasa:cleanup_readme_and_docs

Conversation

@johnjasa
Copy link
Copy Markdown
Collaborator

Update README and docs intro page

Reorganizes and expands the README and docs/intro.md to:

  • reorder content blocks to match user expectations
  • better describe H2Integrate's capabilities as a hybrid systems engineering design and technoeconomic analysis tool.

Section 1: Type of Contribution

  • Feature Enhancement
    • Framework
    • New Model
    • Updated Model
    • Tools/Utilities
    • Other (please describe):
  • Bug Fix
  • Documentation Update
  • CI Changes
  • Other (please describe):

Section 2: General PR Checklist

  • PR description thoroughly describes the new feature, bug fix, etc.
  • Added tests for new functionality or bug fixes
  • Tests pass (If not, and this is expected, please elaborate in the Section 6: Test Results)
  • Documentation
    • Docstrings are up-to-date
    • Related docs/ files are up-to-date, or added when necessary
    • Documentation has been rebuilt successfully
    • Examples have been updated (if applicable)
  • CHANGELOG.md
    • At least one complete sentence has been provided to describe the changes made in this PR
    • After the above, a hyperlink has been provided to the PR using the following format:
      "A complete thought. [PR XYZ]((https://github.com/NatLabRockies/H2Integrate/pull/XYZ)", where
      XYZ should be replaced with the actual number.

Section 3: Related Issues

N/A

Section 4: Impacted Areas of the Software

Section 4.1: New Files

N/A

Section 4.2: Modified Files

  • README.md
    • Reorganized section order: badges/summary, installation (PyPI + link to docs), expanded capabilities overview, publications, citation. Removed inline source install instructions in favor of a docs link.
  • docs/intro.md
    • Expanded opening description, updated technology list, added active development areas, moved citation to bottom before auto-API docs.
  • CHANGELOG.md
    • Added entry for this PR.

Section 5: Additional Supporting Information

N/A

Section 6: Test Results, if applicable

N/A — documentation-only changes.

Section 7 (Optional): New Model Checklist

N/A

Copy link
Copy Markdown
Collaborator

@kbrunik kbrunik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting this whipped up so quickly! I have a few changes I'd like to see before this comes in

Comment thread README.md Outdated

- **Detailed equipment-level modeling** with a wide range of subsystem variation options
- **High-resolution, location-specific resource data** for site-dependent performance modeling
- **Cost inputs settable by the user** with examples based on the Annual Technology Baseline (ATB)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should link the ATB?

Comment thread README.md
See the [Getting Started guide](https://h2integrate.readthedocs.io/en/latest/intro.html) for an introduction to H2Integrate.
The [Examples folder](./examples/) contain Jupyter notebooks and sample YAML files for common usage scenarios.

## Publications
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be interested in moving the publications to the docs and out of the readme and just having a link to the doc page.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think we should include Reznick's paper

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh duh, I meant to and forgot! Thank you. Will add that paper and move it to the docs.

Comment thread docs/intro.md
H2Integrate is designed to be flexible and extensible, allowing users to create their own components and models for various energy systems.
The tool currently includes renewable energy generation (wind, solar, wave, tidal), battery storage, hydrogen, ammonia, methanol, and steel technologies.
Other elements such as desalination systems, pipelines, compressors, and storage systems can also be included as developed by users.
The tool currently includes renewable energy generation (land-based wind, offshore wind, solar PV, wave, tidal), conventional generation (natural gas combined cycle, combustion turbines, grid electricity), hydrogen production (PEM electrolysis, NG-SMR), energy storage (Li-ion batteries, long-duration energy storage, pumped storage hydropower), fuel cells, and industrial processes (ammonia synthesis, iron ore reduction, steel production, methanol, and more).
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather not distinguish between renewable and conventional generation -- because who's to say that some renewables aren't considered conventional at this point?

I also worry that this list is going to be another hard piece to maintain -- like we already have electrowinning and hydrogen storage should those be include? Makes it a long list though

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd want to have something on the splash page about the technologies we have, but it could be more clear that these are at least the technologies we include. Heard about the conventional vs renewables, will update now.

@johnjasa johnjasa requested a review from kbrunik April 15, 2026 15:30
Copy link
Copy Markdown
Collaborator

@jaredthomas68 jaredthomas68 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great clean up. Thanks! I left some non-blocking suggestions and comments. Feel free to use them or not as you see fit.

Comment thread docs/intro.md Outdated
[![DOI 10.5281/zenodo.17903150](https://zenodo.org/badge/DOI/10.5281/zenodo.17903150.svg)](https://zenodo.org/records/17903150)

H2Integrate is an open-source Python package for modeling and designing hybrid energy systems producing electricity, hydrogen, ammonia, steel, and other products.
H2Integrate (H2I) is an open-source Python package for hybrid energy systems engineering design and technoeconomic analysis.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like "hybrid energy systems" is almost obsolete at this point, may just "hybrid systems". (non-blocking, mostly just a thought that someone looking to do steel may leave after this sentence and miss an opportunity.

Comment thread docs/intro.md Outdated

## What is H2Integrate?

H2Integrate is designed to be flexible and extensible, allowing users to create their own components and models for various energy systems.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
H2Integrate is designed to be flexible and extensible, allowing users to create their own components and models for various energy systems.
H2Integrate is designed to be flexible and extensible, allowing users to create their own components and models for various hybrid systems.

Comment thread docs/intro.md Outdated
The tool currently includes renewable energy generation (wind, solar, wave, tidal), battery storage, hydrogen, ammonia, methanol, and steel technologies.
Other elements such as desalination systems, pipelines, compressors, and storage systems can also be included as developed by users.
The tool currently includes renewable energy generation (land-based wind, offshore wind, solar PV, wave, tidal), conventional generation (natural gas combined cycle, combustion turbines, grid electricity), hydrogen production (PEM electrolysis, NG-SMR), energy storage (Li-ion batteries, long-duration energy storage, pumped storage hydropower), fuel cells, and industrial processes (ammonia synthesis, iron ore reduction, steel production, methanol, and more).
Other elements such as desalination systems, pipelines, compressors, and additional storage systems can also be included as developed by users.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence makes it sound like we don't have these technologies right now, but we do. Some minor adjustments may fix it.

Suggested change
Other elements such as desalination systems, pipelines, compressors, and additional storage systems can also be included as developed by users.
Other elements can also be included as developed by users.

Comment thread docs/intro.md Outdated
Other elements such as desalination systems, pipelines, compressors, and storage systems can also be included as developed by users.
The tool currently includes renewable energy generation (land-based wind, offshore wind, solar PV, wave, tidal), conventional generation (natural gas combined cycle, combustion turbines, grid electricity), hydrogen production (PEM electrolysis, NG-SMR), energy storage (Li-ion batteries, long-duration energy storage, pumped storage hydropower), fuel cells, and industrial processes (ammonia synthesis, iron ore reduction, steel production, methanol, and more).
Other elements such as desalination systems, pipelines, compressors, and additional storage systems can also be included as developed by users.
H2Integrate is continually expanding to serve additional hybrid applications, including behind-the-meter data center hybrid design solutions, nuclear generation (small modular reactors), and hydrogen SOEC electrolysis.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this sentence will almost always be out of date. Could we point people to open PRs for an idea of technologies under development?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good idea, at least better than what's there. I'll noodle on it!

Comment thread docs/intro.md Outdated
PDFs are available in the linked titles.

```{note}
H2Integrate was previously known as GreenHEART, and some publications may refer to it by that name.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
H2Integrate was previously known as GreenHEART, and some publications may refer to it by that name.
H2Integrate was previously known as GreenHEART, and some publications refer to it by that name.

Comment thread docs/intro.md

H2Integrate goes into more component-level details than those tools, especially in terms of nonlinear physics-based modeling and design.

## Publications
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would lean towards only including the citations instead of the synopses.

Comment thread README.md Outdated
[![DOI 10.1088/1742-6596/2767/6/062017](https://img.shields.io/badge/DOI-10.1088%2F1742--6596%2F2767%2F6%2F062017-brightgreen?link=[https://doi.org/10.1088/1742-6596/2767/6/062017](https://doi.org/10.1088/1742-6596/2767/6/062017))](https://iopscience.iop.org/article/10.1088/1742-6596/2767/6/062017/pdf)
[![DOI 10.21203/rs.3.rs-4326648/v1](https://img.shields.io/badge/DOI-10.21203%2Frs.3.rs--4326648%2Fv1-brightgreen?link=[https://doi.org/10.21203/rs.3.rs-4326648/v1](https://doi.org/10.21203/rs.3.rs-4326648/v1))](https://assets-eu.researchsquare.com/files/rs-4326648/v1_covered_338a5071-b74b-4ecd-9d2a-859e8d988b5c.pdf?c=1716199726)
H2Integrate (H2I) is an open-source Python package for hybrid energy systems engineering design and technoeconomic analysis.
It models hybrid energy plants that produce electricity, hydrogen, ammonia, steel, and other products to perform optimization and scenario analysis.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
It models hybrid energy plants that produce electricity, hydrogen, ammonia, steel, and other products to perform optimization and scenario analysis.
It models hybrid systems, especially hybrid energy plants, that produce electricity, hydrogen, ammonia, steel, and other products to perform optimization and scenario analysis.

Comment thread README.md Outdated
H2I includes models for a broad set of energy generation, conversion, and storage technologies.
This is a non-exhaustive list, and the library of available technologies is actively expanding:

- **Electricity generation**: solar PV, wind, wave, tidal, natural gas combined cycle (NGCC), natural gas combustion turbines (NGCT), grid
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nuclear

Comment thread README.md Outdated
## Getting Started

See the [Getting Started guide](https://h2integrate.readthedocs.io/en/latest/intro.html) for an introduction to H2Integrate.
The [Examples folder](./examples/) contain Jupyter notebooks and sample YAML files for common usage scenarios.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The [Examples folder](./examples/) contain Jupyter notebooks and sample YAML files for common usage scenarios.
The [Examples folder](./examples/) contain Jupyter notebooks, python scripts, and sample YAML files for common usage scenarios.

Comment thread README.md
## Publications

For a full list of publications, see the [Publications section in the documentation](https://h2integrate.readthedocs.io/en/latest/intro.html#publications).
Note: H2Integrate was previously known as GreenHEART, and some publications may refer to it by that name.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Note: H2Integrate was previously known as GreenHEART, and some publications may refer to it by that name.
Note: H2Integrate was previously known as GreenHEART, and some publications refer to it by that name.

@johnjasa johnjasa enabled auto-merge (squash) April 15, 2026 20:27
@johnjasa johnjasa disabled auto-merge April 15, 2026 20:38
@johnjasa johnjasa merged commit 8914696 into NatLabRockies:develop Apr 15, 2026
12 checks passed
johnjasa added a commit that referenced this pull request Apr 15, 2026
* Remove old iron models (#601)

* removed temporary iron and steel models

* supported models

* update example 28 with updated models

* remove outdated files

* consolidate iron examples

* fix all the stuff I broke

* update docs and changelog

* update example name and add model names to docs

* update changelog

---------

Co-authored-by: elenya-grant <[email protected]>

* update SMR energy conversion ratio and tests (#606)

* update SMR energy conversion ratio and tests

* update changelog

* docs

* minor updates to inline comments

* update usage based on hydrogen production

---------

Co-authored-by: Rob Hammond <[email protected]>
Co-authored-by: elenya-grant <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: genevievestarke <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Co-authored-by: bayc <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Co-authored-by: Jonathan Martin <[email protected]>
Co-authored-by: jmartin4 <[email protected]>
Co-authored-by: Jonathan Martin <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Chris Bay <[email protected]>

* Break out Pyomo controller simulation code (#587)

* Breakout simulation code

* Remove duplicate code

* Fix testing

* Update doc strings and docs

* added docstring for heuristic controller config

* fixed issue that I made with the HeuristicLoadFollowingControllerConfig

* Update docs/control/pyomo_controllers.md

Co-authored-by: Jared Thomas <[email protected]>

* Make initialize_parameters() functions the same for both controllers

* Apply suggestion from @jaredthomas68

Co-authored-by: Jared Thomas <[email protected]>

* Fix doc string format

* Update h2integrate/control/control_strategies/heuristic_pyomo_controller.py

Co-authored-by: Jared Thomas <[email protected]>

* Update h2integrate/control/control_strategies/heuristic_pyomo_controller.py

Co-authored-by: Jared Thomas <[email protected]>

* Fix ruff formatting

---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: elenya-grant <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* Bugfix in Charge/Discharge efficiency handling in `StoragePerformanceModel` (#600)

* fixed how charge and discharge rates are applied in generic_storage_pyo model

---------

Co-authored-by: John Jasa <[email protected]>

* Tests for non-one battery efficiencies (#610)

* add unit tests for  openloop storage controller with non-one efficiencies

* rearrange usage of pytest.approx so the target comes second and uses approx

* update changelog:

* Sync Storage Autosizing Model and Pass-Through controller to Align with Pyomo Controllers (#608)

* updated the storage autosizing and pass through controller for new control and performance model structure

* added subtest for integration with pass through controller

* updated to use commodity_set_point instead of input-demand

* made set_demand_as_avg_commodity_in a required input parameter

* moved passthrough controller to storage subfolder

* Added minor changes that got  missed in PR 600

---------

Co-authored-by: kbrunik <[email protected]>

* Sync Demand Open Loop Controller and Simple Generic Storage to Align with Pyomo Controllers (#612)

* updated simple_generic_storage to simulate storage performance

* updated demand openloop controller so discharge setpoint is correct

* PySAM Marine Models (#607)

* tidal resource model and performance model

* add performance values for testing

* test power curve scaling

* marine cost model

* tidal example

* integration test

* documentation

* update docs

* small changes

* update for failing tests

* fix equation rendering

* fix segmentation fault

* add test for using default pysam config

* address reviewer feedback

* fix wind pysam

* attempt to modify file path handling for resource data

* fix path stuff

* Sync PySAM Battery and Generic Storage Pyomo Performance models with open-loop controllers (#613)

* refactored pysam battery and storage performance models to be compatible with updated open-loop controllers

* updated generic storage pyo to use pass through controller

* renamed PassThroughOpenLoopController to SimpleStorageOpenLoopController

* removed simple_generic_storage

* renamed xx_charge_fraction to xx_soc_fraction

---------

Co-authored-by: Genevieve Starke <[email protected]>

* minor error msg and doc corrections (#618)

* CO2 Model Fixes (#617)

* units and connecting variables

* fix doc page

* catch if annual_input_energy is 0

* remove base class

* fix oae test

* failing doc test

* fix value call

* final touchs

* Bugfix: Update storage models so can use different control types per storage type (#615)

* updated logic in pysam batery and generic storage to handle multiple storage types

* added tests and bugfix in heuristic with setting efficiencies

---------

Co-authored-by: John Jasa <[email protected]>

* Baseclass for Openloop Storage Control Strategies (#619)

* added openloop control storage baseclass

* Enable use of Pyomo Controllers in the Storage Autosizing Model (#621)

* updated autosizing storage model to be compatible with pyomo controllers

* renamed fixures in heuristic controller tests

* aggregated heuristic controller tests into one file

* added simple test for storage autosizing and heuristic

* renamed fixtures in optimized controller tests

* aggregated optimized control tests into one file

* updated test for heuristic controller with autosizing

* updated so simple storage autosizing can run with optimal pyomo control

* Generic cost model for converters (#622)

* added generic cost model

* added tests and updated model

* updated example 3 to use new converter model and added to supported models

* updated docstrings and input descriptions

* updated changelog

* added to model overview

* Clarified error message

---------

Co-authored-by: John Jasa <[email protected]>

* Introducing multivariable commodity streams (#480)

* Working out first steps of multivariable streams

* Adding to multivariable streams work

* expanding multivariable stream definition

* Building out more of the gas combiner

* Improving example for multivariable streams

* Updating examples and merging

* Apply suggestions from code review

Co-authored-by: genevievestarke <[email protected]>

* Many updates based on PR feedback

* Updated to mass fractions for multicommodity stream

* renamed a few multicommodity variable names

* Added helper functions for multivariable stream definitions

* Updated names throughout for multivariable streams

* Updated docs for multivariable streams

* Added commodity stream tests

* Addressing PR feedback

* Updates based on PR feedback

* Updates based on PR feedback

---------

Co-authored-by: genevievestarke <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* Removed some shape_by_conn calls due to OM issues (#632)

* Removed some shape_by_conn calls due to OM issues

* Moved last calls of copy_shape

* Fixing test_pipe fail

---------

Co-authored-by: jmartin4 <[email protected]>

* Move xdsm call in H2IntegrateModel to its own method (#629)

* move xdsm creation in H2IModel to a method so user has to call it if desired instead of having it be automatic

* update changelog and docs and adjust create_xdsm logic to reflect that it is an optional call

* update docs

* update docs

* update docs for visualization

* change xdsm code cell to not execute on build

* switch pdf for png

* minor comments update in code example

* remove xdsm call

* Updated XDSM explanation link

---------

Co-authored-by: John Jasa <[email protected]>

* Handling Leap Years in OpenMeteo Resource Data (#633)

* updated openmeteo resource models to handle leap day

* added resource files for leap year

* added tests for leap year resource data

* added integration w pvwatts test for leap year

* Methodized leap day handling for base class for future resource handling

---------

Co-authored-by: John Jasa <[email protected]>

* Baseclass for Storage Performance Models (#624)

* added draft storage model baseclass

* updated draft storage baseclass

* added docstring to run_storage method

* minor updates to comments in storage_model_baseclass

* updated storage performance model to inherit baseclass

* fixed storage performance model and storage baseclass

* updated storage autosizing model

* updated pysam battery to use baseclass and removed battery_baseclass

* removed commented out code and simplified some docstrings

* removed unnecessary docstrings

* updated changelog

* PR review: minor personal preferences

* updated inline comment

---------

Co-authored-by: John Jasa <[email protected]>

* Modified the calc tilt angle function for pysam solar (#646)

* Oxygen output from PEM electrolyzer (#642)

* added oxygen output from electrolyzer

* updated example 14 to calc LCOO

---------

Co-authored-by: John Jasa <[email protected]>

* Removed remaining naming dependencies (#654)

* Removed remaining naming dependencies

* Added to changelog and fixed CI issue

* PR feedback

* Fixed schema reqs

* Update validators to allow zero values for costs for nuclear

* Bugfix: Connecting resource to multiple techs (#655)

* bugfix and added test for connecting one resource model to multiple techs

* updated changelog

* Updated test to call setup to trigger connection error

---------

Co-authored-by: John Jasa <[email protected]>

* Update urls for NLR pages and github repositories (#658)

* Update urls for NLR pages and github repositories

* Updated from WISDM to NLRWindSystems org for some repos

* Updated and removed more NREL references

---------

Co-authored-by: John Jasa <[email protected]>

* Enhancement/windows ci (#590)

* update installation instructions

* add windows to CI and use conda consistently for Python across OS

* merge develop and update changelog

* adopt 'extras' flag for analysis extras to correctly use optional CI

* update changelog

* reorder ci setup

* update order

* attempt python version restructure

* reinstate old python version

* update URL

* move runs-on back to below strategy

* add os to optional matrix

* reorganize the conditional for extras

* convert lists to yaml bullet lists

* skip gis-dependent tests when not installed

* update changelog

* use optional deps for all tests and add single runner for validating dependency-determined skipped tests

* reformatting

* reduce sql file access scope to functions to avoid windows errors

* downgrade temp_dir to a function scope to avoid windows access errors

* move temp examples fixture to be in main conftest, and enable repo-wide access

* add module scoped example directory copy

* apply module scoped example copy fixture to recorder tests and update

* update changelog

* update miniconda action usage

* use the example copy fixture to isolate sql access in tests for potential windows resolution

* reorganize changelog

* fix typo in parameter name

* update workflow

* remove max-parallel

* Revert "reorganize changelog"

This reverts commit 679a38d.

* add shell to all tests

* don't allow coverage upload to fail ci

* uncomment windows

* add garbage collection to help with sql file handling

* temporarily only run windows to reduce runner usage

* add sleep to see if small timeout resolves issue

* only run single test

* remove garbage collection

* fix typo

* remove manual folder removal in favor of pytest cleanup

* reinstate normal CI processes

* add file removal to avoid OpenMDAO silent failure

* temporarily only run single file on single windows runner

* fix typo

* fix typo

* move manual recorder_path deletion

* put ci back

* handle None case

* track model state using IntEnum

* add xfail for windows because of OpenMDAO improper SQL file handling for Windows

* add todo about removing manual removal

* restore accidentally deleted file

---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* updated CI workflow to disable windows (#668)

* Check for extraneous or mis-categorized input parameters (#647)

* added dictionary utilities

* bugfix in setup() and added start of a test

* added fix to calling check_inputs

* fixed check_inputs

* added another check in check_inputs

* updated error messages in check_inputs and fixed example 1

* Added tests

* added another subtest to test_check_inputs

* fixed tech configs for examples

* added some inline comments

* check for requisite models and return if none

* perform check from note and collapse checking logic

* collapse user input regeneration to reduce number of loops

* remove nested looping approach

* move assert to proper context manager level

* add indent level back

* fix min combinations logic for passing tests

* flatten improperly shared parameterization checking logic

* update test to include multiple categories for improperly shared

* fix typo

* update docstring

* added handling for combined cost and performance models

* Added tech config fpath to the error messages for parameter checking

* changlog

* changed strict to True for six converter models

* reverted strict setting for electrolyzer

---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: Hammond, Rob <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* Update Naming Convention in Open-Loop Converter Control Strategies (#631)

* renamed outputs in converter openloop controllers

* updated tests and examples with updated naming

* added performance model outputs to the converter control strategies

* moved converter control strategies to demand folder

* removed commodity_set_point as output

* renamed demand component to be performance model instead of control strategy

* moved output calculations to shared method in baseclass
---------

Co-authored-by: kbrunik <[email protected]>
Co-authored-by: John Jasa <[email protected]>

* modified state check for setup and run (#669)

* Add interactive class hierarchy visualization to docs (#643)

* Added class hierarchy diagram

* merging

* Updated the PR template

* Changed class hierarchy embedding

* moved class hierachy

* Breaking the sphinx narrow rule

* Combined colors based on feedback

* Updated colors based on Gen's feedback

* Shifted diagram location right

* Reformatting embedding the class viz structure

* Updated dev pyproject for viz tool

---------

Co-authored-by: kbrunik <[email protected]>

* Standardize Feedstock Outputs (follow-on to 463) (#523)

* added capacity and price as inputs to feedstock component

* updated feedstock mdoel to have standard outputs

* added commodity_amount_units to FeedstockCostConfig

* added standard output to feedstock cost model and connected commodity_out between performance and cost model

* renamed config inputs for feedstocks

* updated ex 23 which is untested and cleaned up feedstocks.py

* minor docstring updates and added comments

* added in notes of questions for reviewers to feedstocks.py

* updated MMBtu units to MMBtu/h

* fixed iron and steel tests

* made changes to feedstock

* fixed tests

* removed unused comment

* removed shape from price input

* added integration test for feedstock integrated with finance model

* updated feedstocks.md

* changed based on reviewer feedback

* added subtests to test_feedstocks

* small changes to feedstock doc

* docs

---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: kbrunik <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* Framework to allow for variable dt (#653)

* add draft for variable timestep framework

* Changed error wording

* switch bounds to tuple

* minor test correction

* include time-series generation functions

* add tests for variable dt and update simulation length check for non-hourly dt

* update docs

* update changelog

* update docs and doc strings

* restore develop version of utilities.py

* update dt bounds error

* Apply suggestions from code review

Co-authored-by: Copilot <[email protected]>

* Fixing tests

* Adding time step bounds to all models

* Adding time step bounds to the combiner/splitter/transporters

* Updates for tests

* Adding time step bounds to the custom paper mill performance model

* Added time step bounds to paper mill cost

---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: kbrunik <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: Copilot <[email protected]>

* patch: Variable dt (#671)

* update dt bounds error to require `_time_step_bounds`
* Apply suggestions from code review
Co-authored-by: Copilot <[email protected]>
* Add time step bounds to all tech models
* Apply time step bounds check to feedstocks, transporters, and combiners
---------

Co-authored-by: John Jasa <[email protected]>
Co-authored-by: kbrunik <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: Copilot <[email protected]>

* Remove system-level outputs from storage and replace with demand component (follow-on to 631) (#666)

* removed system level calcs from storage and updated most tests

* updated examples with storage but dont use storage as a commodity_stream in finances

* updated examples with storage defined as a commodity_stream for a finance subgroup

* added time_step_bounds to demand components

* added test for example 23

* added example for different demand between storage and demand component

* added demo for the demand components using example 13

* made it so demand is only input to battery performance model if using feedback control

* added standard_capacity_factor as output from storage

* added doc page for storage performance models

---------

Co-authored-by: kbrunik <[email protected]>
Co-authored-by: John Jasa <[email protected]>
Co-authored-by: kbrunik <[email protected]>

* Updating the readme and intro doc page ahead of v0.8 release (#677)

* Updating the readme

* Updated intro.md and changelog

* Minor readme updates

* Addressing Kaitlin's comments

* Added more lingo to readme

* Addressing PR suggestions

---------

Co-authored-by: kbrunik <[email protected]>

* Move storage controllers into `storage` folder in `control_strategies` (#678)

* moved controllers to storage folder

* renamed pyomo controllers to include storage in the control name

* moved control strategy tests

* moved tests to the right folder

* moved pyomo baseclass and controller_opt_problem_state to top-level control_strategies

* updated import statements

* renamed pyomo baseclass file

* updated import for pyomo storage baseclass

* made storage chapter in docs

* removed backslashes from eqn since they dont render properly on readthedocs

* Making changes per Gen's suggestion (#681)

* Bump version from 0.7.2 to 0.8.0

---------

Co-authored-by: kbrunik <[email protected]>
Co-authored-by: elenya-grant <[email protected]>
Co-authored-by: Rob Hammond <[email protected]>
Co-authored-by: genevievestarke <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Co-authored-by: bayc <[email protected]>
Co-authored-by: Jared Thomas <[email protected]>
Co-authored-by: Jonathan Martin <[email protected]>
Co-authored-by: jmartin4 <[email protected]>
Co-authored-by: Jonathan Martin <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Chris Bay <[email protected]>
Co-authored-by: Genevieve Starke <[email protected]>
Co-authored-by: kbrunik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants